BR? "Preview Mode" - piano keyboard click resets the sample [Fixed]

[DarkStar]

I'm just trying this out and it works very well for quickly previewing different samples.

Here I have loaded a specific snare onto C2 and am previewing others. You will see the sample name change in the group.



All is well until I click the TX16Wx piano keyboard to play the sample - then it reverts back to the originally-loaded sample. I think that this should not be the case - the sample being previewed should remain loaded until the split is reset as described in the user guide (re-select the split, select another split, edit any range parameter) ..

[elcallio]

Clicking the "piano" does not reset the preview loaded state. However, changing the selection does. This is as designed, since preview target is selection sensitive.
In your case, you are clicking the root key, which is a selection action. In this case it is just selecting the same split as was selected though, so it really should not trigger a change event. If I am not mistaken, the change to this behavior came from another bug fix. Too bad it has this somewhat undesirable side effect.

Edit: Sorry, I spoke to soon. The problem is that clicking the root key "edit rectangle" starts and edit (you are editing the root key/root override). Since a previewed item cannot be edited, the previewer must clear out its data when this happens. I have no good workaround for this at the time, other than using a MIDI keyboard...

[DarkStar]

Thank you for the explanation.

But I did not think that clicking a piano keyboard key started any edit process - it does not select any Group or Split.

Even weirder: it works today. Clicking the piano keyboard key triggers the preview sample, not the original.

I'm stumped

[elcallio]

Not the piano, the root edit widget (the orange rectangle).

[DarkStar]

Ah ha - that explains the difference that I saw today. So, to summarise:
-- if I click on the Root key marker the originally loaded sample will be reinstated and played
-- if I click on a black or white piano key then the preview sample will be played.

One for the next issue of the User Guide?

-----------------------
Let me pose another question:

Here I have a one group of mapped samples. I selected the first split (on D2), turned on preview mode and selected a drum stick sample (with a rootkey of C#1). On playing the D2 note, from my keyboard or clicking the TX16Wx's keyboard, the drum stick sample did play but was pitched upwards.

>>> http://i.imgur.com/4Lt45bm.png

I wonder if there's anything that can be done in such cases; I cannot think of anything intuitive., other than "when previewing in the Keyboard Mapper, ignore the embedded root key".

[elcallio]

The click-on-root has been fixed. I'll upload a build soon.
However, your case with the mismatched root keys are WAD imho. If you preview a sample, it should be used at its natural pitch. In the case you present above it might not be exactly what you want, but for a more sane example, where you preview a pitched sample into a pitched split region, it is the desirable outcome.
Fwiw, previewing should respect root key overrides, so if you have an override in your split, you will get the outcome you wanted.

[DarkStar]

WAD?

[elcallio]

Working as designed.

[DarkStar]

Fixed in v2.4.1h