TX16Wx sf2 click issue (v3.4.0r)

[bojanboyss]

Hello. Some back story: I was sitting on TX16Wx for years, never really used it up until now when I wanted to try out how usable is as a soundfont (sf2) player. And, my luck, already found out issue with some almost regular click when pressing note.
I don't know if its my fault somehow but it is fresh install with default settings. I tested sf2 files in other plugins that can play soundfonts and in there, same sf2s, they play fine.
Click happens in the first portion of the waveform so its not at start and not at loop points.
Found on my hdd old vst (.dll) of version v2.4.1b and compared it against v3.4.0r. In older version it plays at lower volume but it doesn't click. I tried "edit-remove dc offset and normalize", lowering volume on few places in sampler, didn't help. Increasing attack of volume envelope a lot - can help, but its too high.

That was in VstHost. Tried in Reaper and got same click issue.
Interesting thing happens when project is saved and reloaded later: no click. Until I load something (or same) again, then its back again.

On a few sfz instruments I tried it played fine. On lot of sf2 from my collection there is this issue.

I made a video about tests in VstHosts (bellow).
Im having issues with v3.4.0r free version (if that matters). Win10 Pro x64. x64 vst2 version of TX16Wx.

Link to sf2 used:
Full pack (1.2Gb): https://archive.org/details/001LoopedInstruments
Just the one used in the video, first preset (64Mb, sf2 name: LP-i-Arracis Gold (512)):
https://ia800104.us.archive.org/view_ar ... 512%29.zip

https://youtu.be/wHO_50_B4lI

[elcallio]

The issue you experience is caused by a rare edge condition in the streamer. It triggers with this SF2 because the samples are rather weird and intentionally sampled at "half" sample rate -> all playback of "normal" pitch is actually resampled down 1 oct or more. Now, depending on your stream buffer setting visavi DAW audio buffer setting, you can hit an edge where the streamer looses track of pitch for _one_ subframe, and resamples slightly wrong for X samples. The reason this has never triggered anyone before is that unless you have such large resample range (+1 oct) this will be so short that the smoothing just wasps it away. But here, at the "right" octave, we can hear it very well.

This was a fun bug to find. Had to look at a lot of recordings and count the samples to figure it out.
You can work around this by simply turning off streaming for these samples.

I'll put up a fixed version in the next beta build tomorrow. At this stage I don't want to make hotfixes to 3.4.

[elcallio]

Fixed in new beta build.

[bojanboyss]

That was quick, thanks! Works good now.

[Nils Schneider]

Just tried to use TX16wx as sf2 player and had the very same issue.

Noticed that it goes away if I disable DFD and use RAM instead. sf2 is 20MB in total size and located on a separate SSD for samples, as the click is constant, I assume it's a DFD issue.

Is there a global option to disable DFD completely? I've got plenty of RAM that's why I would prefer to keep the whole preset in RAM either way.

[elcallio]

There is not, but use the 3.5 beta and it should be fixed.

[Nils Schneider]

There is not, but use the 3.5 beta and it should be fixed.

Perfect fix, works like a charm now, thanks a lot!