Anyway: You're AWESOME, Dakkra, THANK YOU!
One Synth Challenge #132: ToneZ by t0nit0rmx (MrKarollus Wins!)
- KVRAF
- 3209 posts since 17 Apr, 2010 from Slovenia
Well, I gave it a try! Wonna go check it out and tell me, if I did this right?
Anyway: You're AWESOME, Dakkra, THANK YOU!
Anyway: You're AWESOME, Dakkra, THANK YOU!
- KVRAF
- 3209 posts since 17 Apr, 2010 from Slovenia
HOly crap, github isn't "easy" at first. I realized, I did one little mistake after seeing the compares - ridiculous little trip-up in the beginning- but I know not how to update my pull request yet. It's all freaking spanish to me.
...too weird.
MAYBE it worked, maybe?! It's very strange to me. I think, now my update shows compare between my first pull and the update, haha... it's insane. I don't yet like it.

MAYBE it worked, maybe?! It's very strange to me. I think, now my update shows compare between my first pull and the update, haha... it's insane. I don't yet like it.
- KVRAF
- 3209 posts since 17 Apr, 2010 from Slovenia
That's the "Amount". That means, for example, if you put an envelope or LFO on Filter, you control how strong their influence is on the filter. Normally this is also where one would wish for a velocity control, which is something I would want to build into that, too, hehehe, but eh... I don't want to mess with this too much before Tonito really starts hating me?! 
- KVRAF
- 3209 posts since 17 Apr, 2010 from Slovenia
Yes, but now you should really just start trying it out. +100% adds to the value of the target parameter, -100% subtracts from the target. In case of a filter you'd notice the difference very quickly! 
- KVRian
- 1451 posts since 4 Oct, 2012 from Utah
I see two commits in there:
one with the bulk of your changes: https://github.com/T0NIT0RMX/ToneZ/pull ... 441d439cae
and one with a correction: https://github.com/T0NIT0RMX/ToneZ/pull ... a29fb501b6
A note Taron, if you're using command line GIT, you can do commit -m "your message here" to title commits and give them information
The pull request is visible though so overall success! Hopefully T0NIT0 will like your request and merge it. We'll see. They have stated that they don't like high significance (ie more decimals) on parameters. I disagree but ultimately it's up to them 'Tis their synth after all.
Anyway, I'm finally getting some form of a song done with it now. Now that I understand its quirks, I'm able to use it a bit better.
one with the bulk of your changes: https://github.com/T0NIT0RMX/ToneZ/pull ... 441d439cae
and one with a correction: https://github.com/T0NIT0RMX/ToneZ/pull ... a29fb501b6
A note Taron, if you're using command line GIT, you can do commit -m "your message here" to title commits and give them information
The pull request is visible though so overall success! Hopefully T0NIT0 will like your request and merge it. We'll see. They have stated that they don't like high significance (ie more decimals) on parameters. I disagree but ultimately it's up to them 'Tis their synth after all.
Anyway, I'm finally getting some form of a song done with it now. Now that I understand its quirks, I'm able to use it a bit better.
Software portfolio
M.N.I.E - soon to be my musical portfolio
Hey, I'm Eurydice(Izzy for short) - she/her
M.N.I.E - soon to be my musical portfolio
Hey, I'm Eurydice(Izzy for short) - she/her
- KVRian
- 1451 posts since 4 Oct, 2012 from Utah
Another quick thing to note, the synth does have a small delay due to how it builds envelopes. The madsr and mxadsr functions have predelay parameters which do have a value > 0 in the ToneZ code. Here's an example:
And the documentation for those functions:
(linear) http://www.csounds.com/manual/html/madsr.html
(exponential) http://www.csounds.com/manual/html/mxadsr.html
The idel parameter is used, as can be seen in the screenshot (about 1ms delay).
This is called the One Synth Challenge. If there weren't obstacles, it wouldn't be much of a challenge now would it

(linear) http://www.csounds.com/manual/html/madsr.html
(exponential) http://www.csounds.com/manual/html/mxadsr.html
The idel parameter is used, as can be seen in the screenshot (about 1ms delay).
This is called the One Synth Challenge. If there weren't obstacles, it wouldn't be much of a challenge now would it
You do not have the required permissions to view the files attached to this post.
Software portfolio
M.N.I.E - soon to be my musical portfolio
Hey, I'm Eurydice(Izzy for short) - she/her
M.N.I.E - soon to be my musical portfolio
Hey, I'm Eurydice(Izzy for short) - she/her
- KVRAF
- 3209 posts since 17 Apr, 2010 from Slovenia
Yeah, I'm sure I was butchering around in there with little shame, but what comes out now sounds far less butchered than before, hehe.
...but as I said, it's my first time seeing CSound and Cabbage and I'm sure there's plenty to learn, but I don't think I'm too keen on it. I just prefer to do my own thing, really. Still interesting! 
- KVRAF
- 2483 posts since 22 Sep, 2016
@Taron - Sorry to act as assh*** here. But I would reject the pull requests if I'd be Tonito.
I took a short look into it. It changed considerable amounts of lines but not a single line of comment was added.
Slip for a second into the shoes of tonito - how should he know which assumptions you made, what the author considered as problem, why the patch is a fix to the problem and what the side effects might be? In distributed development you have to take care about streamlining processes and one of these is that the maintainer of the master branch is able to understand immediately what is going on in a pull request. Why for instance is the change to 0.001 better then that of Dakkra to 0.000001. Think of where git originaly came from - it's the linux kernel community. Git is afaik a tool from linus himself, so this is a community with quite a number of contributors. Writing good comments helps to keep frustration low on both sides, the pull request commiter and on the maintainer side.
---
Update: Yesterday I've asked Tonito on discord whether he's aware of the pull requests and by when a new release will be available. Seems there was some talks behind the scenes about the pull requests ... but quote from discord: "Also please keep in mind that to make a version for windows and mac I need at least 3 weeks (because I'm not able to make a Mac version myself so I have to ask it to Cabbage dev who kindly provide it to me when he have some time)"
That seems to late for the OSC .. anyway, keep up the work to improve ToneZ. It's a little gem...
I took a short look into it. It changed considerable amounts of lines but not a single line of comment was added.
Slip for a second into the shoes of tonito - how should he know which assumptions you made, what the author considered as problem, why the patch is a fix to the problem and what the side effects might be? In distributed development you have to take care about streamlining processes and one of these is that the maintainer of the master branch is able to understand immediately what is going on in a pull request. Why for instance is the change to 0.001 better then that of Dakkra to 0.000001. Think of where git originaly came from - it's the linux kernel community. Git is afaik a tool from linus himself, so this is a community with quite a number of contributors. Writing good comments helps to keep frustration low on both sides, the pull request commiter and on the maintainer side.
---
Update: Yesterday I've asked Tonito on discord whether he's aware of the pull requests and by when a new release will be available. Seems there was some talks behind the scenes about the pull requests ... but quote from discord: "Also please keep in mind that to make a version for windows and mac I need at least 3 weeks (because I'm not able to make a Mac version myself so I have to ask it to Cabbage dev who kindly provide it to me when he have some time)"
That seems to late for the OSC .. anyway, keep up the work to improve ToneZ. It's a little gem...
- KVRAF
- 3209 posts since 17 Apr, 2010 from Slovenia
It's all fine... never mind. Thanks for the info, Peter! 
Last edited by Taron on Sun Feb 09, 2020 12:16 pm, edited 1 time in total.
- KVRAF
- 3209 posts since 17 Apr, 2010 from Slovenia
- KVRian
- 736 posts since 31 Oct, 2019 from Wonderland
Oooh, Taron, I still want to thank you for your work and hope to wait for your modification of ToneZ, since I would like to continue using this functional synthesizer, but frequent sound interference still prevents its use! And forgive me if I'm wrong, but when the author puts the synthesizer code on Github, doesn't that mean that he wants anyone to be able to modify it freely?
- KVRAF
- 3209 posts since 17 Apr, 2010 from Slovenia
Thanks, IV! There won't be an official modification from me, unless Tonito had already taken it, of course. I can give you my version for sure, but it can't be for this OSC, otherwise you'll have some folks on your case hard!
There's no shortage of synths to come, though, so I wouldn't worry about missing out on anything.
There's no shortage of synths to come, though, so I wouldn't worry about missing out on anything.
- KVRian
- 736 posts since 31 Oct, 2019 from Wonderland
I agree with you as a big fan and "collector" of free synths! And I will definitely finish this month's track on the original version of ToneZ, since I am exploiting its "extraordinary capabilities" with all my might
But I would really like to have a more stable version for the future)
P.S. Not to mention the limit of dreams - that someone took up the revision of Syncla-X...
It seems that soon I will come to the decision to study programming! 
P.S. Not to mention the limit of dreams - that someone took up the revision of Syncla-X...
