One erroneous click while renaming a preset can crash plugins

[Rivanni]

Clicking somewhere in the preset browser while renaming a preset is not what you would commonly do, but it happens to me accidentally from.
When you do, two things can happen, depending on where you click.

1) Right click on a preset to rename it.
- Click in an empty place in the list portion of the the browser (this would be after the last preset in the list)
- Depending on the DAW the rename window is not the top most window anymore*
- Clicking Cancel or OK both crashes the plugin and also the DAW if the plugin is not sand-boxed (Live and Reaper).

*) In Ableton Live it isn't, in Bitwig and Reaper it still is. Because the rename window disappears in Live, it looks like the renaming function is not functioning anymore because a rename window never pops up again. You have to move Live's window and that of the plugin to find the rename window.


2) Right click on a preset to rename it.
- Click in another preset in the list.
- Depending on the DAW the rename window is not the top most window anymore.
- Clicking cancel shows a message that says that the preset cannot be renamed because it already exists. It looks like it wants to apply to name in the rename window to the selected preset. But I expect this message to see when I click OK and not when I click Cancel (although the rename window should never affect a newly selected preset IMO).

When you don't click outside the rename window, the cancel button acts fine. Even the OK button doesn't inform the user about an already existing name.


I tested Ace, Bazille, Diva, Hive, Repro, Zebra and ClourCopy (all the most recent versions).
Happens with both VST2 and VST3 plugins.
The DAW used does not affect the results (I tested with Live, Bitwig and Reaper).

[tasmaniandevil]

Great find, tanks a lot.

The only info missing was if you are on Mac or Win.
But as I could not reproduce any of this on Mac, I guess you are on Windows.

1) Could reproduce the crash on Windows.
It crashes because by clicking on an empty area in the preset list you deselect the preset, so there is nothing to be renamed anymore and the plugin gets confused.

2) It should not be possible to select any other preset while a rename dialog is active.
Again, this isn't possible on Mac, so it's another Windows only bug.

I'll make tickets for those issues in our bug database.

Thx again.

[Rivanni]

You guessed right, I'm on Windows.