KVR Audio

Numanoid · Post by **Numanoid** » Mon May 16, 2016 10:02 pm

Mutant wrote:Because we rarely visit the Instruments forum, we just come here from our participated threads lists.

And when the dev posts this kind of message upstream, what is your conclusion

martin_l wrote:Maybe I just start a new thread here about the release, in case not every one got the KVR news.

Cheers,
Martin

Mutant · Post by **Mutant** » Mon May 16, 2016 10:21 pm

Numanoid wrote:
Mutant wrote:Because we rarely visit the Instruments forum, we just come here from our participated threads lists.
And when the dev posts this kind of message upstream, what is your conclusion
martin_l wrote:Maybe I just start a new thread here about the release, in case not every one got the KVR news.

Cheers,
Martin

"Maybe"

Also Martin has the power to lock this thread, he just need to edit the 1st post and click the lock button.

martin_l · Post by **martin_l** » Mon May 16, 2016 10:40 pm

Dandruff wrote:
martin_l wrote:Edit: also tried 5.18/64 on Windows and it works correctly for me.
Weird, here it doesn't:

OK. I found the problem. While WDL-OL implemented the effGetParamDisplay part, the function for effString2Parameter was missing. I added it to my current build, and now it behaves as expected.

So the bug will be fixed in the next version. I will also have a look at the Flush on Stop thing. May I ask why you think it is important? I would always have the option "Run FX on Stop" on, which should disable the flush on stop behaviour.

Cheers,
Martin

[Note to others: I am replying to this particular issue in this thread. Please, post NEW comments in the new thread viewtopic.php?f=1&t=463227.]

Dandruff · Post by **Dandruff** » Mon May 16, 2016 11:06 pm

martin_l wrote:OK. I found the problem. While WDL-OL implemented the effGetParamDisplay part, the function for effString2Parameter was missing. I added it to my current build, and now it behaves as expected.

So the bug will be fixed in the next version.

Thanks!

martin_l wrote:I will also have a look at the Flush on Stop thing. May I ask why you think it is important?

Not that important but would be cool if it would work. Enabled "Flush FX on stop" in REAPER should clear the buffers on stop. Just tested 11 other VSTi and only PG-8X and one other don't get flushed. All others get flushed properly.

EvilDragon · Post by **EvilDragon** » Mon May 16, 2016 11:19 pm

Not sure, running VirtualCZ here, it also doesn't flush on stop despite that being enabled in Reaper. Zebra too, Korg Legacy Collection... lots of instrument plugins just keep on going after pressing stop, regardless of that feature.

Dandruff · Post by **Dandruff** » Mon May 16, 2016 11:21 pm

Zebra too? U-he Podolski, TyrellN6 and TripleCheese getting flushed here.

EvilDragon · Post by **EvilDragon** » Tue May 17, 2016 8:52 am

Yeah, not here. Not sure why. No matter how I set up "Run FX on stop" part of prefs stuff just keeps on playing after stop.

aciddose · Post by **aciddose** » Thu Jun 02, 2016 9:08 pm

EvilDragon wrote:Not sure, running VirtualCZ here, it also doesn't flush on stop despite that being enabled in Reaper. Zebra too, Korg Legacy Collection... lots of instrument plugins just keep on going after pressing stop, regardless of that feature.

I suspect this is implemented via setting the plug-in state, aka "suspend() / resume()".

It is a very easy fix if desired to reset the state as on init in these functions. The problem is that many hosts call these regularly and the result is a sharp click when you hit start/stop.

Usually it is better to accept the MIDI "all notes off" message and shut off any notes to let them fade out smoothly.

Another option is to send MIDI "all sound off" which should reset all note, velocity, controller and other (after-touch, pressure, program, ...) states immediately. I believe the MIDI doc says "as fast as possible". So rather than merely like sending note-off, this should perform a fast cut on all voices. Something like if release > 100ms, apply a fast 100ms fade (or optionally SET release = 100ms, if the plug-in architecture allows it.)

That said I don't believe many hosts sent "all sound off". This is ultimately the proper message to send. Otherwise we'd need a VST2 extension for an opcode like "init". The VST spec does say set state == init, yet this is really bad design and plug-in authors votes are in

martin_l · Post by **martin_l** » Thu Jun 02, 2016 9:31 pm

aciddose wrote:
EvilDragon wrote:Not sure, running VirtualCZ here, it also doesn't flush on stop despite that being enabled in Reaper. Zebra too, Korg Legacy Collection... lots of instrument plugins just keep on going after pressing stop, regardless of that feature.
I suspect this is implemented via setting the plug-in state, aka "suspend() / resume()".

It is a very easy fix if desired to reset the state as on init in these functions. The problem is that many hosts call these regularly and the result is a sharp click when you hit start/stop.

Usually it is better to accept the MIDI "all notes off" message and shut off any notes to let them fade out smoothly.

Another option is to send MIDI "all sound off" which should reset all note, velocity, controller and other (after-touch, pressure, program, ...) states immediately. I believe the MIDI doc says "as fast as possible". So rather than merely like sending note-off, this should perform a fast cut on all voices. Something like if release > 100ms, apply a fast 100ms fade (or optionally SET release = 100ms, if the plug-in architecture allows it.)

That said I don't believe many hosts sent "all sound off". This is ultimately the proper message to send. Otherwise we'd need a VST2 extension for an opcode like "init". The VST spec does say set state == init, yet this is really bad design and plug-in authors votes are in

In fact, the PG-8X does accept 'All-Notes-Off". The problem described only appears if "Monitoring" is switched on in reaper, and from a Midi-Monitor I can see that reaper for some reason does not send Note-Off (even though sending Note-Off's is enabled in the reaper preferences). I am still investigating.

I have implemented a hack now which sends an internal All-Notes-Off, when it detects that the transport has changed to STOP (or PAUSE), but I am still testing that hack before releasing the next version.

Cheers,
Martin

Dandruff · Post by **Dandruff** » Thu Jun 02, 2016 9:55 pm

martin_l wrote:I can see that reaper for some reason does not send Note-Off (even though sending Note-Off's is enabled in the reaper preferences).

You mean disabled in Preferences? Because it says "Don't send note offs ..."

Maybe also wait for REAPER 5.21 (should have some more fixes for several note-off stuff).

martin_l · Post by **martin_l** » Thu Jun 02, 2016 10:06 pm

Dandruff wrote:
martin_l wrote:I can see that reaper for some reason does not send Note-Off (even though sending Note-Off's is enabled in the reaper preferences).
You mean disabled in Preferences? Because it says "Don't send note offs ..."

Maybe also wait for REAPER 5.21 (should have some more fixes for several note-off stuff).

With enabled, I meant NOT disabled.

But again, it only happens if the track has MONITORING ON. If you switch off the monitoring (of which I am not even sure what it does for MIDI tracks), it works fine.

Martin

Dandruff · Post by **Dandruff** » Thu Jun 02, 2016 10:08 pm

martin_l wrote:With enabled, I meant NOT disabled.

But again, it only happens if the track has MONITORING ON. If you switch off the monitoring (of which I am not even sure what it does for MIDI tracks), it works fine.

Martin

Ok, yeah not sure why REAPER is doing this.

martin_l · Post by **martin_l** » Thu Jun 02, 2016 10:16 pm

Dandruff wrote:
martin_l wrote:With enabled, I meant NOT disabled.

But again, it only happens if the track has MONITORING ON. If you switch off the monitoring (of which I am not even sure what it does for MIDI tracks), it works fine.

Martin
Ok, yeah not sure why REAPER is doing this.

I hope that next weekend I will find some more time to investigate that. I have seen that you also posted in the reaper forum. Did you bookmark the thread? I can't find it anymore...

Edit: found it:

http://forum.cockos.com/showthread.php?t=177070

aciddose · Post by **aciddose** » Thu Jun 02, 2016 11:43 pm

Monitoring connects the MIDI input to the plug-in chain just as it connects the audio inputs.

Sounds like a recent regression in REAPER.

Dandruff · Post by **Dandruff** » Fri Jun 03, 2016 1:03 am

?

Don't understand this.

PG8X (inspired by the JX8P): new beta version uploaded